multi bot partly working; bots won't shut up though
Some checks failed
Builds / Discord-Node-Build (push) Has been cancelled
Builds / Discord-Ollama-Container-Build (push) Has been cancelled
Coverage / Discord-Node-Coverage (push) Has been cancelled
Deploy / Deploy-Application (push) Has been cancelled

This commit is contained in:
2025-05-21 21:46:47 -04:00
parent 9ffe94ad09
commit d3fd88da04
4 changed files with 276 additions and 325 deletions

View File

@@ -1,9 +1,10 @@
import { describe, expect, it, vi } from 'vitest'
import events from '../src/events/index.js'
import { Client, TextChannel, User, Message } from 'discord.js'
import { Client, TextChannel, Message } from 'discord.js'
import { redis, ollama } from '../src/client.js'
import { Queue } from '../src/queues/queue.js'
import { UserMessage } from '../src/utils/index.js'
import fs from 'fs/promises'
// Mock Redis client
vi.mock('../src/client.js', () => ({
@@ -12,8 +13,8 @@ vi.mock('../src/client.js', () => ({
set: vi.fn().mockResolvedValue('OK'),
},
ollama: {
chat: vi.fn(), // Mock the chat method for messageCreate
pull: vi.fn(), // Retain mock for pull method
chat: vi.fn(),
pull: vi.fn(),
},
}))
@@ -32,7 +33,7 @@ describe('Events Tests', () => {
expect(eventsString).toBe('ready, messageCreate, interactionCreate, threadDelete')
})
// Test messageCreate event for bot-to-bot response
// Test messageCreate event
describe('messageCreate', () => {
const messageCreateEvent = events.find(e => e.key === 'messageCreate')
if (!messageCreateEvent) throw new Error('messageCreate event not found')
@@ -40,12 +41,13 @@ describe('Events Tests', () => {
it('should respond to bot message with random chance and respect cooldown', async () => {
const client = { user: { id: 'bot1', username: 'TestBot' } } as Client
const message = {
id: 'msg1',
author: { id: 'bot2', bot: true, tag: 'OtherBot#1234', username: 'OtherBot' },
content: 'Hello from another bot!',
mentions: { has: () => false },
channelId: 'channel1',
channel: { name: 'test-channel' } as TextChannel,
reply: vi.fn(),
reply: vi.fn().mockResolvedValue({ id: 'reply1' }),
attachments: { first: () => null },
guildId: 'guild1',
} as unknown as Message
@@ -56,10 +58,15 @@ describe('Events Tests', () => {
// Mock random chance to pass (10% probability)
vi.spyOn(Math, 'random').mockReturnValue(0.05)
// Mock Redis: no cooldown initially
vi.mocked(redis.get).mockResolvedValueOnce(null) // No last_bot_response
vi.mocked(redis.get).mockResolvedValueOnce('0.50') // Bot sentiment for bot2
vi.mocked(redis.get).mockResolvedValueOnce('0.50') // Self sentiment
// Mock Redis
vi.mocked(redis.get).mockImplementation(async (key: string) => {
if (key === 'message:msg1:is_bot_response') return null // No is_bot_response
if (key === 'bot:bot1:last_bot_response') return null // No last_bot_response
if (key === 'user:bot2:sentiment') return '0.50' // Bot sentiment
if (key === 'bot:self_sentiment') return '0.50' // Self sentiment
if (key === 'channel:channel1:OtherBot:history') return JSON.stringify([]) // Empty history
return null
})
// Mock fs for personality.json
vi.spyOn(fs, 'readFile').mockResolvedValue(
@@ -81,8 +88,6 @@ describe('Events Tests', () => {
},
})
),
getChannelInfo: vi.fn((_, cb) => cb({ messages: [] })),
openChannelInfo: vi.fn(),
openConfig: vi.fn(),
}))
@@ -118,12 +123,21 @@ describe('Events Tests', () => {
expect.any(String),
{ EX: 60 }
)
expect(redis.set).toHaveBeenCalledWith('message:reply1:is_bot_response', 'true', { EX: 3600 })
expect(redis.set).toHaveBeenCalledWith(
'channel:channel1:OtherBot:history',
JSON.stringify([
{ role: 'user', content: 'Hello from another bot!', images: [] },
{ role: 'assistant', content: 'Hmph, another bot, huh? Trying to steal my spotlight?', images: [] },
])
)
expect(msgHist.size()).toBe(2) // User message + bot response
})
it('should skip bot message response if within cooldown', async () => {
const client = { user: { id: 'bot1', username: 'TestBot' } } as Client
const message = {
id: 'msg2',
author: { id: 'bot2', bot: true, tag: 'OtherBot#1234', username: 'OtherBot' },
content: 'Hello again!',
mentions: { has: () => false },
@@ -142,7 +156,48 @@ describe('Events Tests', () => {
// Mock Redis: within cooldown
const currentTime = Math.floor(Date.now() / 1000)
vi.mocked(redis.get).mockResolvedValueOnce((currentTime - 30).toString()) // Cooldown active
vi.mocked(redis.get).mockImplementation(async (key: string) => {
if (key === 'message:msg2:is_bot_response') return null // No is_bot_response
if (key === 'bot:bot1:last_bot_response') return (currentTime - 30).toString() // Cooldown active
return null
})
// Execute messageCreate event
await messageCreateEvent.execute(
{ log: console.log, msgHist, ollama, client, defaultModel },
message
)
expect(message.reply).not.toHaveBeenCalled()
expect(redis.set).not.toHaveBeenCalled()
expect(msgHist.size()).toBe(0) // No messages added
})
it('should skip bot response to another bot response', async () => {
const client = { user: { id: 'bot1', username: 'TestBot' } } as Client
const message = {
id: 'msg3',
author: { id: 'bot2', bot: true, tag: 'OtherBot#1234', username: 'OtherBot' },
content: 'Im responding to you!',
mentions: { has: () => false },
channelId: 'channel1',
channel: { name: 'test-channel' } as TextChannel,
reply: vi.fn(),
attachments: { first: () => null },
guildId: 'guild1',
} as unknown as Message
const msgHist = new Queue<UserMessage>()
msgHist.capacity = 50
const defaultModel = 'aidoll-gemma3-12b-q6:latest'
// Mock random chance to pass
vi.spyOn(Math, 'random').mockReturnValue(0.05)
// Mock Redis: message is a bot response
vi.mocked(redis.get).mockImplementation(async (key: string) => {
if (key === 'message:msg3:is_bot_response') return 'true' // is_bot_response
return null
})
// Execute messageCreate event
await messageCreateEvent.execute(
@@ -158,12 +213,13 @@ describe('Events Tests', () => {
it('should respond to user mention', async () => {
const client = { user: { id: 'bot1', username: 'TestBot' } } as Client
const message = {
id: 'msg4',
author: { id: 'user1', bot: false, tag: 'User#1234', username: 'User' },
content: '<@bot1> Hi!',
mentions: { has: (id: string) => id === 'bot1' },
channelId: 'channel1',
channel: { name: 'test-channel' } as TextChannel,
reply: vi.fn(),
reply: vi.fn().mockResolvedValue({ id: 'reply2' }),
attachments: { first: () => null },
guildId: 'guild1',
} as unknown as Message
@@ -191,11 +247,17 @@ describe('Events Tests', () => {
},
})
),
getChannelInfo: vi.fn((_, cb) => cb({ messages: [] })),
openChannelInfo: vi.fn(),
openConfig: vi.fn(),
}))
// Mock Redis
vi.mocked(redis.get).mockImplementation(async (key: string) => {
if (key === 'user:user1:sentiment') return '0.50'
if (key === 'bot:self_sentiment') return '0.50'
if (key === 'channel:channel1:User:history') return JSON.stringify([])
return null
})
// Mock Ollama response
vi.mocked(ollama.chat).mockResolvedValue({
message: {
@@ -225,12 +287,20 @@ describe('Events Tests', () => {
expect(message.reply).toHaveBeenCalledWith('U-um... hi... you talking to me?')
expect(redis.set).toHaveBeenCalledWith('user:user1:sentiment', '0.50')
expect(redis.set).toHaveBeenCalledWith('bot:self_sentiment', '0.50')
expect(redis.set).toHaveBeenCalledWith(
'channel:channel1:User:history',
JSON.stringify([
{ role: 'user', content: '<@bot1> Hi!', images: [] },
{ role: 'assistant', content: 'U-um... hi... you talking to me?', images: [] },
])
)
expect(msgHist.size()).toBe(2) // User message + bot response
})
it('should not respond to own message', async () => {
const client = { user: { id: 'bot1', username: 'TestBot' } } as Client
const message = {
id: 'msg5',
author: { id: 'bot1', bot: true, tag: 'TestBot#1234', username: 'TestBot' },
content: 'I said something!',
mentions: { has: () => false },
@@ -254,5 +324,92 @@ describe('Events Tests', () => {
expect(redis.set).not.toHaveBeenCalled()
expect(msgHist.size()).toBe(0) // No messages added
})
it('should handle missing channel history in Redis', async () => {
const client = { user: { id: 'bot1', username: 'TestBot' } } as Client
const message = {
id: 'msg6',
author: { id: 'user1', bot: false, tag: 'User#1234', username: 'User' },
content: '<@bot1> Hi!',
mentions: { has: (id: string) => id === 'bot1' },
channelId: 'channel1',
channel: { name: 'test-channel' } as TextChannel,
reply: vi.fn().mockResolvedValue({ id: 'reply3' }),
attachments: { first: () => null },
guildId: 'guild1',
} as unknown as Message
const msgHist = new Queue<UserMessage>()
msgHist.capacity = 50
const defaultModel = 'aidoll-gemma3-12b-q6:latest'
// Mock fs for personality.json
vi.spyOn(fs, 'readFile').mockResolvedValue(
JSON.stringify({
character: 'You are Kuroki Tomoko, a shy and socially awkward high school girl from WataMote.',
})
)
// Mock utils functions
vi.mock('../src/utils/index.js', () => ({
clean: vi.fn(content => content),
getServerConfig: vi.fn((_, cb) => cb({ options: { 'toggle-chat': true } })),
getUserConfig: vi.fn((_, cb) =>
cb({
options: {
'message-style': false,
'switch-model': 'aidoll-gemma3-12b-q6:latest',
'modify-capacity': 50,
},
})
),
openConfig: vi.fn(),
}))
// Mock Redis: no history
vi.mocked(redis.get).mockImplementation(async (key: string) => {
if (key === 'user:user1:sentiment') return '0.50'
if (key === 'bot:self_sentiment') return '0.50'
if (key === 'channel:channel1:User:history') return null // No history
return null
})
// Mock Ollama response
vi.mocked(ollama.chat).mockResolvedValue({
message: {
content: JSON.stringify({
status: 'success',
reply: 'U-um... hi... you talking to me?',
metadata: {
timestamp: '2025-05-21T14:00:00Z',
self_sentiment: 0.50,
user_sentiment: { 'user1': 0.50 },
redis_ops: [
{ action: 'set', key: 'user:user1:sentiment', value: 0.50 },
{ action: 'set', key: 'bot:self_sentiment', value: 0.50 },
],
need_help: false,
},
}),
},
})
// Execute messageCreate event
await messageCreateEvent.execute(
{ log: console.log, msgHist, ollama, client, defaultModel },
message
)
expect(message.reply).toHaveBeenCalledWith('U-um... hi... you talking to me?')
expect(redis.set).toHaveBeenCalledWith('user:user1:sentiment', '0.50')
expect(redis.set).toHaveBeenCalledWith('bot:self_sentiment', '0.50')
expect(redis.set).toHaveBeenCalledWith(
'channel:channel1:User:history',
JSON.stringify([
{ role: 'user', content: '<@bot1> Hi!', images: [] },
{ role: 'assistant', content: 'U-um... hi... you talking to me?', images: [] },
])
)
expect(msgHist.size()).toBe(2) // User message + bot response
})
})
})